Skip to content

feat: Add dashboard listing page#1971

Open
pulpdrew wants to merge 1 commit intomainfrom
drew/dashboard-listing-page
Open

feat: Add dashboard listing page#1971
pulpdrew wants to merge 1 commit intomainfrom
drew/dashboard-listing-page

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Mar 23, 2026 •
edited
Loading

Summary

This PR introduces a new dashboards listing page, which lists the available dashboards. Each individual dashboard is no longer listed in the sidebar. The new listing page supports searching by name and filtering by tag. This PR is a continuation of @elizabetdev's #1805, with some changes, additional tests, and refactorings.

This page does client-side sort and filter. There is no server-side pagination, filtering, or sorting. That is left as a future improvement, should it become necessary.

Screenshots or video

Screenshot 2026-03-24 at 7 45 54 AM Screenshot 2026-03-24 at 7 45 43 AM Screenshot 2026-03-24 at 7 45 34 AM

How to test locally or on Vercel

The listing page can be tested in vercel preview.

References

  • Linear Issue: Closes HDX-3788
  • Related PRs:

@vercel
Copy link

vercel bot commented Mar 23, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 24, 2026 0:34am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 35b517e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026 •
edited
Loading

Knip - Unused Code Analysis

⚪ 0 change in total issues (240 on main → 240 on PR)

Category main PR Diff
Unused files 9 9 0
Unused dependencies 14 14 0
Unused devDependencies 20 20 0
Unlisted dependencies 14 14 0
Unresolved imports 2 2 0
Unlisted binaries 2 2 0
Unused exports 132 132 0
Unused exported types 41 41 0
Unused enum members 2 2 0
Duplicate exports 4 4 0
What is this?

Knip finds unused files, dependencies, and exports in your codebase.
This comment compares the PR branch against main to detect regressions.

Run yarn knip locally to see full details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026 •
edited
Loading

PR Review

  • ⚠️ Unused Tooltip import from recharts in DashboardsListPage.tsx:6 → Remove it (lint should catch this; verify make ci-lint passes)

  • ⚠️ Changeset bump type mismatch: New feature is marked patch in .changeset/tender-fans-retire.md → Should be minor per semver conventions for a new user-facing feature

  • ⚠️ File length: DashboardsListPage.tsx is 318 lines, slightly over the 300-line guideline in AGENTS.md → Consider extracting the empty-state or toolbar section into a small sub-component

  • ℹ️ window.open(href, '_blank') in DashboardListRow.tsx:21,28 is missing noopener noreferrer → Add window.open(href, '_blank', 'noopener,noreferrer') (low risk for internal links, but best practice)

@pulpdrew pulpdrew changed the title Drew/dashboard listing page feat: Add dashboard listing page Mar 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 100 passed • 3 skipped • 977s

Status Count
✅ Passed 100
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from e39e4b7 to 93059ca Compare March 23, 2026 21:07
@pulpdrew pulpdrew requested a review from elizabetdev March 23, 2026 21:24
@pulpdrew pulpdrew requested review from a team and removed request for a team March 23, 2026 21:25
@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from fc203a3 to b170c22 Compare March 23, 2026 21:41
@pulpdrew pulpdrew marked this pull request as draft March 23, 2026 21:53
@pulpdrew pulpdrew removed request for a team and elizabetdev March 23, 2026 21:59
@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from b170c22 to 5422d25 Compare March 24, 2026 11:44
@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from 5422d25 to 5a41a1b Compare March 24, 2026 11:50
@pulpdrew pulpdrew marked this pull request as ready for review March 24, 2026 11:51
@pulpdrew pulpdrew mentioned this pull request Mar 24, 2026
Closed
@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from 5a41a1b to c8fe7a7 Compare March 24, 2026 12:18
@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from c8fe7a7 to 35b517e Compare March 24, 2026 12:31
@pulpdrew pulpdrew requested review from a team and teeohhem and removed request for a team March 24, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teeohhem teeohhem Awaiting requested review from teeohhem teeohhem was automatically assigned from hyperdxio/hyperdx-team

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pulpdrew